Add ref support to withTheme HOC #915
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Published version: @draftbit/[email protected] |
|
Published version: @draftbit/[email protected] |
YoussefHenna
previously approved these changes
Aug 7, 2024
| }; | ||
| ) => { | ||
| return React.forwardRef( | ||
| (props: Omit<Props, "theme">, ref: React.Ref<any>) => { |
There was a problem hiding this comment.
With components that need a forwarded ref, I usually don't wrap them in a withTheme, instead I get the theme by using the useTheme hook and just export them as is. See the AudioPlayerWithInterface.tsx for example. By doing that, the type of the ref can be maintained and is not any like it is here. This works as well though, it'll just lose the type, but I'm fine with merging it
There was a problem hiding this comment.
Thanks, adjust BottomSheet component
YoussefHenna
approved these changes
Aug 7, 2024
|
Published version: @draftbit/[email protected] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Demo
Screen.Recording.2024-08-07.at.10.14.39.mov