Support isLooping for audio player #925
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Published version: @draftbit/[email protected] |
YoussefHenna
requested changes
Aug 11, 2024
| @@ -97,6 +101,7 @@ const HeadlessAudioPlayer = React.forwardRef< | |||
|
|
|||
| const { sound } = await Audio.Sound.createAsync(finalSource); | |||
| setCurrentSound(sound); | |||
| sound.setIsLoopingAsync(isLooping); | |||
There was a problem hiding this comment.
This will only set the value when the audio is reloaded (audio source changes). Maybe we should have a separate useEffect that updates the looping state
React.useEffect(() => {
currentSound?.setIsLoopingAsync(isLooping);
}, [isLooping])There was a problem hiding this comment.
We can remove this one now since we have the other useEffect @sieu-db. Calling setCurrentSound will cause the other useEffect to run
Suggested change
| sound.setIsLoopingAsync(isLooping); |
There was a problem hiding this comment.
Yep, got it, thanks
packages/core/src/components/MediaPlayer/AudioPlayer/AudioPlayerWithInterface.tsx
Outdated
Show resolved
Hide resolved
packages/core/src/components/MediaPlayer/AudioPlayer/AudioPlayerCommon.ts
Outdated
Show resolved
Hide resolved
… sieu/p-5279-add-loop-prop-audio-player
|
Published version: @draftbit/[email protected] |
|
Adjust this one 🙏 @YoussefHenna |
|
Published version: @draftbit/[email protected] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Demo
Screen.Recording.2024-08-09.at.20.04.58.mov