Skip to content

Add support for onRefresh on scroll views #926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 11, 2024
Merged

Add support for onRefresh on scroll views #926

merged 1 commit into from
Aug 11, 2024

Conversation

YoussefHenna
Copy link
Collaborator

  • This prop is available to list components but not scroll view, this adds support for it.

@linear Linear
Copy link

linear bot commented Aug 11, 2024

P-5304 Scroll view triggers are not working as expected

@github-actions GitHub Actions
Copy link

Published version: @draftbit/[email protected]

sieu-db
sieu-db reviewed Aug 11, 2024
View reviewed changes
Copy link
Collaborator

@sieu-db sieu-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@YoussefHenna YoussefHenna merged commit 304f6f9 into master Aug 11, 2024
3 checks passed
@YoussefHenna YoussefHenna deleted the youssef/p-5304-scroll-view-triggers-are-not-working-as-expected branch August 11, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sieu-db sieu-db sieu-db left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YoussefHenna @sieu-db