Fix media upload resource url #117
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MlkMahmud trying to clean up some of the open PRs, can you add a test case with your changes? Thanks. |
|
Sure thing. @rlueder |
…o fix/media-upload
- maintain client config verison when setting resource url
MlkMahmud
commented
Aug 15, 2021
| @@ -218,7 +218,7 @@ describe('posting', () => { | |||
|
|
|||
| describe('uploading', () => { | |||
| let uploadClient; | |||
| beforeAll(() => (uploadClient = newClient('upload'))); | |||
There was a problem hiding this comment.
@rlueder edited the upload test suite, so users don't have to explicitly edit the subdomain on calls to the media endpoints.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets the correct url for the 'media/upload' endpoint