-
Notifications
You must be signed in to change notification settings - Fork 1.1k
fix(tiering): implement qlist symmetric cooloff and fix memory handling #6496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
🤖 Augment PR SummarySummary: Improves list tiering support in Changes:
🤖 Was this summary useful? React with 👍 or 👎 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implements the symmetric cooloff logic for QList tiering that walks from both ends of the list and offloads nodes beyond the threshold. Fixes memory handling bugs in move operator and null pointer check. Changes: - Implement symmetric cooloff in CoolOff() for balanced tiering - Fix InsertNode() null pointer check when insert_opt is AFTER - Fix move operator to properly reset num_offloaded_nodes_ - Add Stats::operator+= for cross-shard aggregation - Add Prometheus metrics for list reads and tiering events - Add list_tiering_threshold flag for configuration - Fix typo: "overlaoding" -> "overloading" Co-Authored-By: Claude Sonnet 4.5 <[email protected]> Signed-off-by: Roman Gershman <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Co-authored-by: Copilot <[email protected]> Signed-off-by: Roman Gershman <[email protected]>
Co-authored-by: Copilot <[email protected]> Signed-off-by: Roman Gershman <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Implements the symmetric cooloff logic for QList tiering that walks from both ends of the list and offloads nodes beyond the threshold. Fixes memory handling bugs in move operator and null pointer check.
Important: everything is done in dry-run - no actual tiering happens.
Changes: