catch edge case of no object id for query selector

drashland · May 2, 2024 · e6f7db9 · e6f7db9
1 parent 30fc43c
commit e6f7db9
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 8 deletions.
diff --git a/src/element.ts b/src/element.ts
@@ -31,6 +31,8 @@ export class Element {
   /**
    * ObjectId belonging to this element
    */
+  readonly #objectId: string;
+
   readonly #node: ProtocolTypes.DOM.Node;
 
   /**
@@ -43,8 +45,10 @@ export class Element {
     selector: string,
     page: Page,
     node: ProtocolTypes.DOM.Node,
+    objectId: string,
   ) {
     this.#node = node;
+    this.#objectId = objectId;
     this.#page = page;
     this.#selector = selector;
   }
@@ -108,7 +112,7 @@ export class Element {
       "DOM.setFileInputFiles",
       {
         files: files,
-        nodeId: this.#node.nodeId,
+        objectId: this.#objectId,
         backendNodeId: this.#node.backendNodeId,
       },
     );
@@ -210,7 +214,7 @@ export class Element {
       ProtocolTypes.DOM.GetContentQuadsRequest,
       ProtocolTypes.DOM.GetContentQuadsResponse
     >("DOM.getContentQuads", {
-      nodeId: this.#node.nodeId,
+      objectId: this.#objectId,
     });
     const layoutMetrics = await this.#page.send<
       null,

diff --git a/src/page.ts b/src/page.ts
@@ -305,16 +305,23 @@ export class Page extends ProtocolClass {
         'The selector "' + selector + '" does not exist inside the DOM',
       );
     }
+
+    if (!result.result.objectId) {
+      await this.client.close("Unable to find the object");
+    }
+
     const { node } = await this.send<
       ProtocolTypes.DOM.DescribeNodeRequest,
       ProtocolTypes.DOM.DescribeNodeResponse
     >("DOM.describeNode", {
       objectId: result.result.objectId,
     });
+
     return new Element(
       selector,
       this,
       node,
+      result.result.objectId as string,
     );
   }
 

diff --git a/tests/unit/element_test.ts b/tests/unit/element_test.ts
@@ -9,12 +9,6 @@ const serverAdd = `http://${
 }:1447`;
 Deno.test("element_test.ts", async (t) => {
   await t.step("click()", async (t) => {
-    await t.step(
-      "Can handle things like downloads opening new tab then closing",
-      async () => {
-      },
-    );
-
     await t.step(
       "It should allow clicking of elements and update location",
       async () => {