Toggle datatypes for table directly from view dropdown #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
can be discussed later
|
@flashpunch0-0 is attempting to deploy a commit to the dottle's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
1ilit
reviewed
Mar 16, 2025
| ) : ( | ||
| <i className="bi bi-toggle-off" /> | ||
| ), | ||
| function: () => { |
There was a problem hiding this comment.
Suggested change
| function: () => { | |
| function: () => | |
| setSettings((prev) => ({ | |
| ...prev, | |
| showDataTypes: !prev.showDataTypes, | |
| })), |
Please make sure to update the state using the setSettings function. Also the build fails here, please take a lokk https://github.com/drawdb-io/drawdb/actions/runs/13877624768/job/38843669905?pr=366
1ilit
requested changes
Mar 16, 2025
| ? "(" + fieldData.size + ")" | ||
| : "")} | ||
| </span> | ||
| {settings.showDataTypes && ( |
There was a problem hiding this comment.
Also try putting the condition before the div so that an emty element doesnt get added to the dom
…e_datatypes_for_table_flashpunch
…ement in table.jsx code in the else part im directly returning the element by keeping a check for settings.showDataTypes? which helps to not add empty element for setSetting issue I used the similar code used just above the snippet and modified it
|
@1ilit happy to contribute to this product |
|
For sure, looking forward to it, thanks for all your work |
ewqazxc
pushed a commit
to ewqazxc/drawdb
that referenced
this pull request
Mar 17, 2025
* showDatatype setting added in view control panel * removed shortcut can be discussed later * fixed linting issue and made sure the condition check is above div element in table.jsx code in the else part im directly returning the element by keeping a check for settings.showDataTypes? which helps to not add empty element for setSetting issue I used the similar code used just above the snippet and modified it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
proposed implementation
1- initially thought of creating a separate context and hook but the settings context did the provide a good base
2- added an attribute(showDataTypes) in settings context
3- in the en.js file created a reference
4- In the ControlPanel.jsx file under view dropdown created the option show Datatype
5- finally in the table.jsx added condition to check settings.showDatatypes and return the element as per condition
working
datatype -> onshow
datatype-> off
Reference issue and pr #346