Skip to content

fix: CDATA Escaping #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 24, 2025
Merged

fix: CDATA Escaping #217

merged 1 commit into from
Jul 24, 2025

Conversation

monoxgas
Copy link
Contributor

@monoxgas monoxgas commented Jul 24, 2025 •
edited by github-actions bot
Loading

Notes

  • Fix a bug in CDATA auto-insertion that could cause failures

Generated Summary

  • Updated regex pattern in both docs/api/model.mdx and rigging/model.py to require a whitespace character before the tag attributes.
  • Wrapped the substitution result with an XML parsing check using ET.fromstring; if invalid XML is detected, the original content is returned.
  • These changes ensure that wrapping fields with CDATA does not accidentally produce malformed XML, maintaining data integrity.

This summary was generated with ❤️ by rigging

@monoxgas monoxgas requested a review from a team as a code owner July 24, 2025 00:10
@dreadnode-renovate-bot dreadnode-renovate-bot bot added area/docs Changes to documentation and guides type/docs Documentation updates and improvements labels Jul 24, 2025
@monoxgas monoxgas merged commit d1dd655 into main Jul 24, 2025
7 checks passed
@monoxgas monoxgas deleted the fix/cdata-escaping branch July 24, 2025 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/docs Changes to documentation and guides type/docs Documentation updates and improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@monoxgas