Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(render-engine): page and paragraph layout #4157

Open
wants to merge 18 commits into
base: dev
Choose a base branch
from
Open

Conversation

Jocs
Copy link
Contributor

@Jocs Jocs commented Nov 26, 2024

close https://github.com/dream-num/univer-pro/issues/3512

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Nov 26, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Nov 26, 2024

Playwright test results

failed  4 failed
passed  17 passed

Details

stats  21 tests across 10 suites
duration  6 minutes, 4 seconds
commit  c630ff9
info  For more information, see full report

Failed tests

chromium › visual-comparison/sheets/sheets-scroll.spec.ts › cells rendering after scrolling
chromium › visual-comparison/sheets/sheets-scroll.spec.ts › rendering after scrolling by API
chromium › visual-comparison/sheets/sheets-visual-comparison.spec.ts › diff demo sheet content
chromium › visual-comparison/sheets/sheets-visual-comparison.spec.ts › diff merged cells rendering

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 1.07527% with 276 lines in your changes missing coverage. Please review.

Project coverage is 33.10%. Comparing base (9ad9d48) to head (c630ff9).
Report is 8 commits behind head on dev.

Files with missing lines Patch % Lines
...ne-render/src/components/docs/layout/model/line.ts 0.00% 46 Missing ⚠️
...-render/src/components/docs/layout/doc-skeleton.ts 0.00% 34 Missing ⚠️
...onents/docs/layout/block/paragraph/layout-ruler.ts 0.00% 25 Missing ⚠️
...ne-render/src/components/docs/layout/model/page.ts 0.00% 22 Missing ⚠️
...render/src/components/docs/layout/model/section.ts 0.00% 21 Missing ⚠️
...cs-ui/src/services/selection/convert-rect-range.ts 0.00% 18 Missing ⚠️
.../engine-render/src/components/docs/layout/tools.ts 0.00% 18 Missing ⚠️
.../components/docs/layout/block/paragraph/shaping.ts 0.00% 17 Missing ⚠️
...i/src/views/doc-image-panel/DocDrawingPosition.tsx 0.00% 10 Missing ⚠️
...ontrollers/doc-drawing-update.render-controller.ts 0.00% 9 Missing ⚠️
... and 12 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4157      +/-   ##
==========================================
- Coverage   33.14%   33.10%   -0.05%     
==========================================
  Files        2548     2549       +1     
  Lines      131410   131587     +177     
  Branches    29285    29332      +47     
==========================================
  Hits        43562    43562              
- Misses      87848    88025     +177     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jocs Jocs force-pushed the feat/page-layout branch 6 times, most recently from 286482b to fc9a2a6 Compare December 3, 2024 02:38
@Jocs Jocs marked this pull request as ready for review December 3, 2024 02:38
@oumomomo oumomomo added qa:untested This PR is ready to be tested qa:rejected labels Dec 3, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Dec 6, 2024
@Jocs Jocs force-pushed the feat/page-layout branch from fc9a2a6 to 16f6021 Compare January 3, 2025 11:37
@Jocs Jocs requested a review from weird94 as a code owner January 3, 2025 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants