-
-
Notifications
You must be signed in to change notification settings - Fork 695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: split skeleton into core and render-engine #4330
Open
lumixraku
wants to merge
5
commits into
dev
Choose a base branch
from
feat/facade-sk
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
View Deployment
|
Playwright test resultsDetails 21 tests across 10 suites |
lumixraku
force-pushed
the
feat/facade-sk
branch
3 times, most recently
from
December 19, 2024 03:34
3bc5e0a
to
145e6fe
Compare
lumixraku
requested review from
yuhongz,
weird94,
DR-Univer and
Dushusir
as code owners
December 19, 2024 03:34
lumixraku
force-pushed
the
feat/facade-sk
branch
2 times, most recently
from
December 19, 2024 03:49
6d759ce
to
8846dd8
Compare
lumixraku
force-pushed
the
feat/facade-sk
branch
5 times, most recently
from
December 25, 2024 06:27
a800b69
to
118837c
Compare
Dushusir
reviewed
Dec 25, 2024
Consider inviting QA to ensure quality for major changes |
Dushusir
approved these changes
Dec 25, 2024
wzhudev
approved these changes
Dec 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
lumixraku
force-pushed
the
feat/facade-sk
branch
from
January 6, 2025 10:03
118837c
to
bb1261f
Compare
lumixraku
force-pushed
the
feat/facade-sk
branch
3 times, most recently
from
January 6, 2025 12:11
6e4f03a
to
b56d28b
Compare
lumixraku
force-pushed
the
feat/facade-sk
branch
from
January 6, 2025 12:14
b56d28b
to
69486fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close https://github.com/dream-num/univer-pro/issues/3788
engine-render/sheet-skeleton ----> engine-render/sheet-render.skeleton & core/sheet-skeleton
For more details check https://github.com/dream-num/univer-pro/issues/3788
Pull Request Checklist