Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: prepare auto complete #4458

Closed
wants to merge 10 commits into from
Closed

feat: prepare auto complete #4458

wants to merge 10 commits into from

Conversation

lumixraku
Copy link
Contributor

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@lumixraku lumixraku marked this pull request as draft January 11, 2025 03:47
Copy link

github-actions bot commented Jan 11, 2025

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Jan 11, 2025

Codecov Report

Attention: Patch coverage is 0.66778% with 595 lines in your changes missing coverage. Please review.

Project coverage is 32.68%. Comparing base (d5cc9a7) to head (eac23cb).

Files with missing lines Patch % Lines
...i/src/services/canvas-float-dom-manager.service.ts 0.00% 288 Missing ⚠️
packages/sheets-ui/src/facade/f-worksheet.ts 0.00% 73 Missing ⚠️
...eets-ui/src/services/canvas-pop-manager.service.ts 0.00% 73 Missing ⚠️
...ckages/ui/src/views/components/popup/dom-popup.tsx 0.00% 32 Missing ⚠️
...src/views/components/popup/single-canvas-popup.tsx 0.00% 32 Missing ⚠️
...ckages/sheets-drawing-ui/src/facade/f-worksheet.ts 0.00% 28 Missing ⚠️
...ages/ui/src/views/components/popup/CanvasPopup.tsx 0.00% 16 Missing ⚠️
packages/sheets-ui/src/facade/f-range.ts 0.00% 12 Missing ⚠️
packages/sheets-ui/src/facade/f-event.ts 0.00% 10 Missing ⚠️
...ine-render/src/components/sheets/sheet-skeleton.ts 0.00% 8 Missing ⚠️
... and 6 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4458      +/-   ##
==========================================
- Coverage   32.80%   32.68%   -0.12%     
==========================================
  Files        2582     2584       +2     
  Lines      132884   133405     +521     
  Branches    29534    29651     +117     
==========================================
+ Hits        43589    43610      +21     
- Misses      89295    89795     +500     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lumixraku lumixraku force-pushed the feat/prepare-auto-complete branch 4 times, most recently from 1e46ee0 to 2ce91fe Compare January 13, 2025 09:25
Copy link

github-actions bot commented Jan 13, 2025

Playwright test results

failed  1 failed
passed  22 passed

Details

stats  23 tests across 10 suites
duration  6 minutes, 37 seconds
commit  eac23cb
info  For more information, see full report

Failed tests

chromium › memory/memory.spec.ts › memory

@lumixraku lumixraku force-pushed the feat/prepare-auto-complete branch from 3cd8803 to eac23cb Compare January 14, 2025 11:16
@lumixraku lumixraku self-assigned this Jan 14, 2025
@lumixraku lumixraku closed this Feb 5, 2025
@jikkai jikkai deleted the feat/prepare-auto-complete branch February 5, 2025 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant