Fix mappings #228
Open
Fix mappings #228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This hasnt changed your actual function, you should do that as you know how your VMM works
dreamos82
reviewed
Mar 21, 2025
| // 2 = Write | ||
| // 4 = Execute | ||
| // They can be mixed. | ||
| // Conversion |
There was a problem hiding this comment.
The table (I think lol) in my original comment was referring to the elf flags for the memory segments, that differ from the VM ones (that are the paging flags).
| PF_X | 0x1 | Execute |
| PF_W | 0x2 | Write |
| PF_R | 0x4 | Read |
So apparently even my comment was wrong XD (i don't even remember if there was something else too in the mappings code). Anyway i notice a typo on the line above , can you fix that too?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This hasnt changed your actual function, you should do that as you know how your VMM works
See osdev-notes-2025-01-19.pdf page=258