-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DDF for Sonoff ZBMini R2 Extreme (ZBMINIR2) #8034
base: master
Are you sure you want to change the base?
Conversation
But you miss the c++ part ? The validator don't reconise "range" here
|
Hey @duffbeer2000, thanks for your pull request! Tip Modified bundles can be downloaded here. DDB changesModified
ValidationTip Everything is fine ! 🕐 Updated for commit dad115b |
Update de_web_plugin.cpp for sonoff buttonmap
But you miss the c++ part ? --> Like I mentioned in my commit "add zbminir2 to button_maps, needs changes from smanars pull request …" and discord chat ;) but I made a pull from your fork now. The validator don't reconise "range" here" --> corrected that one |
The PR adds a new item
|
@manup I'm afraid following the line of argumentation of the manup from the past, that would be a no. The item at hand would be a prime example of such a response. However, that brings me once again to the topic of not having any guidance when we might want to expose a resource item and when not. If new ones are exposed, documentation is often lacking or incomplete. I would personally like to introduce additional 5-10 items but haven't done so, as they do not necessarily match to the requirement(s) discussed. |
I don't understand why we need two items, Also not happy about the myriad of modes taking device-specific values: I agree with @SwoopX that we need more guidance on when and how to introduce resource items. Ideally, the API would become self-describing, so API clients don't need to rely on (outdated or missing) documentation. It would definitely like to see |
Product name: Sonoff ZBMini R2 Extreme
Manufacturer: Sonoff
Model identifier: ZBMINIR2
Device Type: Smart Switch
Fixes Issue #8020 with help of @Smanar