Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial port of RandomAccessStream/ReaderInfo #361

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

kwhopper
Copy link
Collaborator

@kwhopper kwhopper commented Sep 9, 2018

Port of drewnoakes/metadata-extractor-dotnet#130

The description and purpose are the same as in the C# pull request and issue:
drewnoakes/metadata-extractor-dotnet#131

Enhances or resolves the following issues:
#357
#351
#232 (support for this one, but commented out after the first SoS)

Some notable changes:

  • The file or stream length is always required, either as an input or extracted from a seekable stream. This solves all kinds of EOF and semi-infinite loop problems.
  • JpegSegmentReader implements the C# experimental approach to reading jpeg segments beyond the first SoS marker. This could be configurable in the future to allow all segments (including image data) to be accessible in some fashion.
  • Just like the C# version, this PR corrects and records the global file/stream position of all tag data. This should allow future support for writing large byte arrays directly to disk or ignoring them altogether safely.

My Java skills aren't as refined as my C# skills. It would be great if someone could review. Thanks

@kwhopper kwhopper removed the request for review from nagix September 24, 2018 20:54
@haumacher
Copy link

This would also allow fixing #149 and answering question #276 satisfactory?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants