[turso] Allows authToken to be empty string #3933
Open
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
authToken especially provided by env variable could be an empty string, relaxing the validation would allow it to pass instead of forcing developer to create a branching case for providing credentials
authToken especially provided by env variable could be an empty string, relaxing the validation would allow it to pass instead of forcing developer to create a branching case for providing credentials
…katok/drizzle-orm into libsql-authtoken-empty-string
|
hmmm, is my previous unverified commit an issue? should I create another branch and create another PR from it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
authTokenespecially provided by env variable could be an empty string, relaxing the validation would allow it to pass instead of forcing developer to create a branching case for providing credentialsCurrently, when
authTokenis provided as an empty string, validation message is outputted though is not exactly clear.Without relaxing the validation, developer would need to use a branch case.
