Handle EINTR to avoid crashing tests when debugging #156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running tests with a debugger on Linux, Mio's poll function may return EINTR (interrupted system call) after halting on breakpoints, which causes the test to panic. The documentation for std::io::ErrorKind::Interrupted states that "interrupted operations can typically be retried." This commit adds a conditional to ignore this specific error and continue polling.
hornang
force-pushed
the
handle-eintr-to-avoid-crashing-tests-when-debugging
branch
from
92a8971 to
2e6cc92
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have experienced that the unit tests crashes when running them with a debugger and stopping at breakpoints. This is inconvenient.
I found out that it is probably the debugger's signal handlers that interferes with the system calls inside Mio as described in the libc manual.
The
EINTRerror propagates up to code intlsserver.rsand it seems I can handle this by ignoring that particular error and callpoll()again.