Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[개선] 공통 모듈에서 사용할 수 있는 UI 파일 분리 #326

Closed
wants to merge 6 commits into from
Closed

[개선] 공통 모듈에서 사용할 수 있는 UI 파일 분리 #326

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
cf912ad
refactor: 모서리가 둥근 이미지를 RoundedImage 컴포넌트로 분리
tmdgh1592 Jun 5, 2024
f049c2f
refactor: 아이콘 버튼을 RoundedToggleButton 컴포넌트로 분리
tmdgh1592 Jun 5, 2024
a8f20f7
refactor: RoundedImage 함수가 Modifier를 전달받지 않도록 변경
tmdgh1592 Jun 5, 2024
b406031
refactor: RoundedImage 함수에 border 인자 추가
tmdgh1592 Jun 5, 2024
0a824a2
refactor: RoundedImage가 size를 전달받도록 변경
tmdgh1592 Jun 5, 2024
1e07d29
refactor: RoundedImage, IconToggleButton 제거
tmdgh1592 Jun 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions feature/session/src/main/java/com/droidknights/app/feature/session/SessionDetailScreen.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ import androidx.compose.foundation.verticalScroll
import androidx.compose.material3.CircularProgressIndicator
import androidx.compose.material3.HorizontalDivider
import androidx.compose.material3.Icon
import androidx.compose.material3.IconToggleButton
import androidx.compose.material3.MaterialTheme
import androidx.compose.material3.Text
import androidx.compose.runtime.Composable
Expand Down Expand Up @@ -276,7 +275,7 @@ private fun BookmarkToggleButton(
bookmarked: Boolean,
onClickBookmark: (Boolean) -> Unit,
) {
IconToggleButton(
androidx.compose.material3.IconToggleButton(
checked = bookmarked,
onCheckedChange = onClickBookmark
) {
Expand Down
Loading