Skip to content

InstrumentedExecutorService registered metrics cleanup after shutdown#3202

Merged
joschi merged 17 commits intodropwizard:release/4.2.xfrom
the-thing:2920/remove_gauges_on_shutdown
Oct 3, 2024
Merged

InstrumentedExecutorService registered metrics cleanup after shutdown#3202
joschi merged 17 commits intodropwizard:release/4.2.xfrom
the-thing:2920/remove_gauges_on_shutdown

Conversation

@the-thing
Copy link
Contributor

Fixes #2920

Additional metrics registed in InstrumentedExecutorService constructors are cleaned up after shutdown.

@the-thing the-thing requested review from a team as code owners February 22, 2023 12:35
@joschi joschi added the bug label Oct 3, 2024
@joschi joschi added this to the 4.2.28 milestone Oct 3, 2024
Copy link
Member

@joschi joschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@the-thing Thanks a lot for your contribution! ❤️

@joschi joschi merged commit 90fa922 into dropwizard:release/4.2.x Oct 3, 2024
@the-thing the-thing deleted the 2920/remove_gauges_on_shutdown branch October 3, 2024 13:34
joschi pushed a commit that referenced this pull request Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

InstrumentedExecutorService does not remove registered gauges after shutdown

2 participants