Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Promotion Condition page. #264

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
+267 −3
Open

Create Promotion Condition page. #264

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
73d4b86
A start on conditions docs. Need to rename photo.
nloewen-AcroMedia Dec 3, 2018
159ce78
Added Condition Interface code.
nloewen-AcroMedia Dec 5, 2018
d855563
Outline
nloewen-AcroMedia Dec 7, 2018
6dc7eed
Do I need php tag?
nloewen-AcroMedia Dec 7, 2018
959036d
Focust on OrderItmeQuantity.
nloewen-AcroMedia Dec 7, 2018
1d74910
Waiting for feedback.
nloewen-AcroMedia Dec 7, 2018
4549114
Move most content to core/conditions. Break into sections.
nloewen-AcroMedia Dec 12, 2018
305eed3
Fleshed out writeup. Ready for feedback.
nloewen-AcroMedia Dec 12, 2018
b92189a
Removed 'Fill out this section' tagline.
nloewen-AcroMedia Dec 12, 2018
938932c
Cleaned up core/conditions based on pull request feedback.
nloewen-AcroMedia Dec 14, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Waiting for feedback.
@nloewen-AcroMedia
nloewen-AcroMedia committed Dec 7, 2018
commit 1d74910527f5ec50624b39336ffb4e50255072ab
5 changes: 2 additions & 3 deletions ...ges/03.commerce2/02.developer-guide/09.promotions/02.create-a-condition/docs.md
View file
Original file line number Diff line number Diff line change
@@ -106,8 +106,7 @@ User story:

![Add Promotion UI](create-a-promotion.png)

[OrderItemQuantity.php](https://cgit.drupalcode.org/commerce/tree/modules/promotion/src/Plugin/Commerce/Condition/OrderItemQuantity.php)
---

```php
<?php // namespace & use
/**
@@ -221,6 +220,6 @@ class OrderItemQuantity extends ConditionBase implements ParentEntityAwareInterf

}
```

[OrderItemQuantity.php](https://cgit.drupalcode.org/commerce/tree/modules/promotion/src/Plugin/Commerce/Condition/OrderItemQuantity.php)

! We need help filling out this section! Feel free to follow the *edit this page* link and contribute.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll want to remove the ! We need help... section.