Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement DNS HTTPS RR (RFC 9460) #2484

Draft
wants to merge 5 commits into
base: 3.2
Choose a base branch
from
Draft

Implement DNS HTTPS RR (RFC 9460) #2484

wants to merge 5 commits into from

Conversation

drwetter
Copy link
Owner

@drwetter drwetter commented Mar 30, 2024 •
edited
Loading

What is your change about?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Typo fix
  • Documentation update
  • Update of other files

If it's a code change please check the boxes which are applicable:

  • For the main program: My edits contain no tabs and the indentation is five spaces
  • I've read CONTRIBUTING.md and Coding_Convention.md
  • I have tested this fix against >=2 hosts and I couldn't spot a problem
  • [TODO] I have tested this new feature against >=2 hosts which show this feature and >=2 host which does not (in order to avoid side effects) . I couldn't spot a problem
  • [TODO] For the new feature I have made corresponding changes to the documentation and / or to help()
  • [TODO] If it's a bigger change: I added myself to CREDITS.md (alphabetical order) and the change to CHANGELOG.md

Open: when ASSUME_HTTP is set and no services was detected, this needs to be handled

@drwetter
Start working on DNS HTTPS RR (RFC 9460)
c93f06c 
- Initial commit, saving work
- Simple test: just copied get_caa_rrecord

Also renamed Just copied get_caa_rr_record to get_caa_rrecord to remove the
redundant r
@drwetter
First proper output for HTTPS RR
e6bdcee 
- moved function + output to the very top (still not the right place)
- raw_https now should contain the output in any case, binhex parse needs to be completed
- fixed bug that CAA records were queried when it was instructed to minimize/skip or use proxy only
@drwetter drwetter self-assigned this Mar 30, 2024
@drwetter drwetter marked this pull request as draft March 30, 2024 16:24
@drwetter drwetter mentioned this pull request Mar 30, 2024
Open
@drwetter drwetter changed the title Implement DNS HTTPS RR *(RFC 9460) Implement DNS HTTPS RR (RFC 9460) Sep 5, 2024
@drwetter
Intro section improvements, placement of DNS RR output
e26e665 
- intro section has now bold keys and plain values
- DNS RR is now below rDNS, if servive is HTTP

Open: when ASSUME_HTTP is set and no services was detected, this needs to be handled
@drwetter
Copy link
Owner Author

drwetter commented Sep 5, 2024

status

image

@drwetter
Copy link
Owner Author

drwetter commented Sep 7, 2024

Note to self

  • Move the line to protocols but cache the entry so that for multiple IPs we don't query DNS again
  • fix testssl.sh template so that CI run passes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@drwetter drwetter

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@drwetter