Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed: #7 #11
Partially Fixes: #6
Link to org repo issue: dsc-x/omg-frames#2
Changes Made
1. User model updated
New fields 'Role' and 'Organisation' are added to the user model. So the request body for register has to be changed accordingly. The new request body is
2. REST Conventions
Keeping the REST conventions in mind, some changes were made:
So right now when the login request is successful the response contains:
Also, when a
POST
request is made to/frames
it returns3. Delete frame method added
A new method
DELETE
is added. It requires anid
as a query, also the API-key should be provided in the header.e.g.
4. APIDocs were updated with these changes
Files changed