track record file positions to allow for record editing #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the file positions of each record to the parsing code.
Motivation: I have a garmin 66i that occasionally produces bad records ( corrupt time and/or very inaccurate gps coordinates). With this record data added to fitparse, I was able to write a second script (based on fitdump) that as it reads a .fit file will write a new .fit file removing the bad records, keeping all other records and updating the checksums and other header data. That "fixfit.py" script is in my fork. It's not very polished so not included here.
Submitting this PR, in case there is any interest in this type of capability. longer term it would be great to see a python based .fit editor