Fix profile loading when passed an explicit profile #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtanx
commented
Sep 27, 2025
Collaborator
|
Hi @jtanx , Thanks for the PR! Can you rebase and merge with the v1.4-andium branch and target that as your base branch? That should fix the build error. |
Author
|
ah yep, done |
Profiles should be read out of the config file, not credentials file
Author
|
Are there instructions for running the minio tests locally? |
Author
|
Alright I just ran the actions on my fork and the tests work now. |
Author
|
@Tmonster any chance for another review? |
|
@Tmonster +1! |
Tmonster
approved these changes
Nov 4, 2025
| // get the profile from within that file | ||
| Aws::Map<Aws::String, Aws::Config::Profile> profiles; | ||
| Aws::Config::AWSConfigFileProfileConfigLoader loader(credentials_file_path); | ||
| Aws::Config::AWSConfigFileProfileConfigLoader loader(config_file_path, true); |
Collaborator
There was a problem hiding this comment.
Maybe in the future we will want a setting for the useProfilePrefix, but don't think that is needed here
Author
|
Nice, thanks for reviewing; do I also need someone else to review to be able to merge? |
Collaborator
|
nope, thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Profiles should be read out of the config file, not credentials file
I believe this fixes #111