Pass the compilers using CMAKE_XXX_COMPILER instead of XXX env variable #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous method of setting the CC and friends environment variables causes some issues with some vcpkg ports. Sometimes a port must be compiled for the host, but when the CC env variable is set, this overwrites all settings. This leads to a situation where code that must be compiled for the host architecture (eg amd64) will be compiled with an arm64 cross-compiler.
|
Looks good to me, thanks @JAicewizard! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Semi-unsolicited PR, below small explanation on why this is needed. Also tagging @hannes as this is one of the changes we discussed on friday WRT the getting faiss extension in the community repo.
The previous method of setting the CC and friends environment variables causes some issues with some vcpkg ports. Sometimes a port must be compiled for the host, but when the CC env variable is set, this overwrites all settings. This leads to a situation where code that must be compiled for the host architecture (eg amd64) will be compiled with an arm64 cross-compiler.