Skip to content

Allow vcpkg custom git url #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Conversation

JAicewizard
Copy link
Contributor

Hello! one last PR. This PRs adds the option for extensions to use their own fork of vcpkg. The use-case may be small, but I think the risk is also small, as this is just passing down the option to run-vcpkg. I hope this would be possible to add!

@JAicewizard
Copy link
Contributor Author

PS. I already tested this with the faiss extension, once this is merged it can go to the community repo

Copy link
Collaborator

@samansmink samansmink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds sane to me!

@samansmink samansmink merged commit b07a1a6 into duckdb:main Aug 27, 2024
18 of 19 checks passed
@JAicewizard JAicewizard deleted the custom_vcpkg branch August 27, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants