Skip to content

Initialize class members #819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2025
Merged

Initialize class members #819

merged 1 commit into from
Jun 5, 2025

Conversation

Y--
Copy link
Collaborator

@Y-- Y-- commented Jun 5, 2025

While working on #804 I realized that we were living dangerously having some potentially un-initialized pointers.

This PR adds the -Weffc++ compilation flag to make sure they all are.

@Y-- Y-- force-pushed the yl/init-class-members branch from f4c9db0 to ef24d78 Compare June 5, 2025 09:51
JelteF
JelteF previously approved these changes Jun 5, 2025
Base automatically changed from yl/member-guard-2 to main June 5, 2025 10:12
@Y-- Y-- dismissed JelteF’s stale review June 5, 2025 10:12

The base branch was changed.

@Y-- Y-- force-pushed the yl/init-class-members branch from ef24d78 to 2a03e4f Compare June 5, 2025 10:33
@Y-- Y-- requested a review from JelteF June 5, 2025 10:33
@Y-- Y-- force-pushed the yl/init-class-members branch from 2a03e4f to f481b63 Compare June 5, 2025 10:33
@Y-- Y-- enabled auto-merge (squash) June 5, 2025 10:33
@Y-- Y-- merged commit b1a6083 into main Jun 5, 2025
6 checks passed
@Y-- Y-- deleted the yl/init-class-members branch June 5, 2025 10:53
@dpxcc dpxcc mentioned this pull request Jun 5, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants