Support MotherDuck views #822
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JelteF
force-pushed
the
duckdb-views
branch
2 times, most recently
from
2d8df06 to
4904c78
Compare
Y--
reviewed
Jun 6, 2025
| @@ -63,7 +63,7 @@ jobs: | |||
|
|
|||
| # If main or tag, then push to `pgduckdb/pgduckdb` | |||
| git fetch --tags --force | |||
| if [ "$BRANCH" = "main" ] || git rev-parse --verify $BRANCH^{tag} > /dev/null 2>&1; then | |||
| if [ "$BRANCH" = "main" ] || [ "$BRANCH" = "duckdb-views" ] || git rev-parse --verify $BRANCH^{tag} > /dev/null 2>&1; then | |||
There was a problem hiding this comment.
Why this change? You want to publish a docker version for this branch?
There was a problem hiding this comment.
Yeah it's so people can test this stuff easily without merging the PR. I'll make sure to remove it before we merge this.
src/pgduckdb_background_worker.cpp
Outdated
| return; | ||
| } | ||
|
|
||
| elog(WARNING, "AAAA: %s", create_query.c_str()); |
There was a problem hiding this comment.
I assume it's a leftover? :-)
Not sure how to catch these without running MD tests?
…ion after renaming
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for creating, querying and syncing VIEWs from MotherDuck.
Views created by
CREATE VIEWget created in MotherDuck if one of thefollowing conditions is met:
ddb$schema.duckdb.force_motherduck_viewsis set totrue.Fixes #474