-
Notifications
You must be signed in to change notification settings - Fork 908
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add developer settings for importing passwords from Google Password M…
…anager
- Loading branch information
Showing
30 changed files
with
983 additions
and
290 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
92 changes: 92 additions & 0 deletions
92
.../autofill-impl/src/main/java/com/duckduckgo/autofill/impl/importing/CredentialImporter.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,92 @@ | ||
| /* | ||
| * Copyright (c) 2024 DuckDuckGo | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package com.duckduckgo.autofill.impl.importing | ||
|
|
||
| import android.os.Parcelable | ||
| import com.duckduckgo.app.di.AppCoroutineScope | ||
| import com.duckduckgo.autofill.api.domain.app.LoginCredentials | ||
| import com.duckduckgo.autofill.impl.importing.CredentialImporter.ImportResult | ||
| import com.duckduckgo.autofill.impl.importing.CredentialImporter.ImportResult.Finished | ||
| import com.duckduckgo.autofill.impl.importing.CredentialImporter.ImportResult.InProgress | ||
| import com.duckduckgo.autofill.impl.store.InternalAutofillStore | ||
| import com.duckduckgo.common.utils.DispatcherProvider | ||
| import com.duckduckgo.di.scopes.AppScope | ||
| import com.squareup.anvil.annotations.ContributesBinding | ||
| import dagger.SingleInstanceIn | ||
| import javax.inject.Inject | ||
| import kotlinx.coroutines.CoroutineScope | ||
| import kotlinx.coroutines.flow.Flow | ||
| import kotlinx.coroutines.flow.MutableSharedFlow | ||
| import kotlinx.coroutines.launch | ||
| import kotlinx.parcelize.Parcelize | ||
|
|
||
| interface CredentialImporter { | ||
| suspend fun import( | ||
| importList: List<LoginCredentials>, | ||
| originalImportListSize: Int, | ||
| ) | ||
|
|
||
| fun getImportStatus(): Flow<ImportResult> | ||
|
|
||
| sealed interface ImportResult : Parcelable { | ||
|
|
||
| @Parcelize | ||
| data object InProgress : ImportResult | ||
|
|
||
| @Parcelize | ||
| data class Finished( | ||
| val savedCredentials: Int, | ||
| val numberSkipped: Int, | ||
| ) : ImportResult | ||
| } | ||
| } | ||
|
|
||
| @SingleInstanceIn(AppScope::class) | ||
| @ContributesBinding(AppScope::class) | ||
| class CredentialImporterImpl @Inject constructor( | ||
| private val autofillStore: InternalAutofillStore, | ||
| private val dispatchers: DispatcherProvider, | ||
| @AppCoroutineScope private val appCoroutineScope: CoroutineScope, | ||
| ) : CredentialImporter { | ||
|
|
||
| private val _importStatus = MutableSharedFlow<ImportResult>(replay = 1) | ||
|
|
||
| override suspend fun import( | ||
| importList: List<LoginCredentials>, | ||
| originalImportListSize: Int, | ||
| ) { | ||
| appCoroutineScope.launch(dispatchers.io()) { | ||
| doImportCredentials(importList, originalImportListSize) | ||
| } | ||
| } | ||
|
|
||
| private suspend fun doImportCredentials( | ||
| importList: List<LoginCredentials>, | ||
| originalImportListSize: Int, | ||
| ) { | ||
| var skippedCredentials = originalImportListSize - importList.size | ||
|
|
||
| _importStatus.emit(InProgress) | ||
|
|
||
| val insertedIds = autofillStore.bulkInsert(importList) | ||
|
|
||
| skippedCredentials += (importList.size - insertedIds.size) | ||
| _importStatus.emit(Finished(savedCredentials = insertedIds.size, numberSkipped = skippedCredentials)) | ||
| } | ||
|
|
||
| override fun getImportStatus(): Flow<ImportResult> = _importStatus | ||
| } |
94 changes: 94 additions & 0 deletions
94
...ofill-impl/src/main/java/com/duckduckgo/autofill/impl/importing/CsvCredentialConverter.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,94 @@ | ||
| /* | ||
| * Copyright (c) 2024 DuckDuckGo | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package com.duckduckgo.autofill.impl.importing | ||
|
|
||
| import android.net.Uri | ||
| import android.os.Parcelable | ||
| import com.duckduckgo.autofill.api.domain.app.LoginCredentials | ||
| import com.duckduckgo.autofill.impl.importing.CsvCredentialConverter.CsvCredentialImportResult | ||
| import com.duckduckgo.common.utils.DispatcherProvider | ||
| import com.duckduckgo.di.scopes.AppScope | ||
| import com.squareup.anvil.annotations.ContributesBinding | ||
| import javax.inject.Inject | ||
| import kotlinx.coroutines.withContext | ||
| import kotlinx.parcelize.Parcelize | ||
|
|
||
| interface CsvCredentialConverter { | ||
| suspend fun readCsv(encodedBlob: String): CsvCredentialImportResult | ||
| suspend fun readCsv(fileUri: Uri): CsvCredentialImportResult | ||
|
|
||
| sealed interface CsvCredentialImportResult : Parcelable { | ||
|
|
||
| @Parcelize | ||
| data class Success(val numberCredentialsInSource: Int, val loginCredentialsToImport: List<LoginCredentials>) : CsvCredentialImportResult | ||
|
|
||
| @Parcelize | ||
| data object Error : CsvCredentialImportResult | ||
| } | ||
| } | ||
|
|
||
| @ContributesBinding(AppScope::class) | ||
| class GooglePasswordManagerCsvCredentialConverter @Inject constructor( | ||
| private val parser: CsvCredentialParser, | ||
| private val fileReader: CsvFileReader, | ||
| private val credentialValidator: ImportedCredentialValidator, | ||
| private val domainNameNormalizer: DomainNameNormalizer, | ||
| private val dispatchers: DispatcherProvider, | ||
| private val blobDecoder: GooglePasswordBlobDecoder, | ||
| private val existingCredentialMatchDetector: ExistingCredentialMatchDetector, | ||
| ) : CsvCredentialConverter { | ||
|
|
||
| override suspend fun readCsv(encodedBlob: String): CsvCredentialImportResult { | ||
| return kotlin.runCatching { | ||
| withContext(dispatchers.io()) { | ||
| val csv = blobDecoder.decode(encodedBlob) | ||
| convertToLoginCredentials(csv) | ||
| } | ||
| }.getOrElse { CsvCredentialImportResult.Error } | ||
| } | ||
|
|
||
| override suspend fun readCsv(fileUri: Uri): CsvCredentialImportResult { | ||
| return kotlin.runCatching { | ||
| withContext(dispatchers.io()) { | ||
| val csv = fileReader.readCsvFile(fileUri) | ||
| convertToLoginCredentials(csv) | ||
| } | ||
| }.getOrElse { CsvCredentialImportResult.Error } | ||
| } | ||
|
|
||
| private suspend fun convertToLoginCredentials(csv: String): CsvCredentialImportResult { | ||
| return when (val parseResult = parser.parseCsv(csv)) { | ||
| is CsvCredentialParser.ParseResult.Success -> { | ||
| val toImport = deduplicateAndCleanup(parseResult.credentials) | ||
| CsvCredentialImportResult.Success(parseResult.credentials.size, toImport) | ||
| } | ||
| is CsvCredentialParser.ParseResult.Error -> CsvCredentialImportResult.Error | ||
| } | ||
| } | ||
|
|
||
| private suspend fun deduplicateAndCleanup(allCredentials: List<LoginCredentials>): List<LoginCredentials> { | ||
| val dedupedCredentials = allCredentials.distinct() | ||
| val validCredentials = dedupedCredentials.filter { credentialValidator.isValid(it) } | ||
| val normalizedDomains = domainNameNormalizer.normalizeDomains(validCredentials) | ||
| val entriesNotAlreadySaved = filterNewCredentials(normalizedDomains) | ||
| return entriesNotAlreadySaved | ||
| } | ||
|
|
||
| private suspend fun filterNewCredentials(credentials: List<LoginCredentials>): List<LoginCredentials> { | ||
| return existingCredentialMatchDetector.filterExistingCredentials(credentials) | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.