This repository was archived by the owner on Feb 24, 2025. It is now read-only.
Send pixel on sync secure storage read failure #1058
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sync-secure-storage-failure
dus7
approved these changes
Nov 5, 2024
samsymons
added a commit
that referenced
this pull request
Nov 6, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review the release process for BrowserServicesKit here.
Required:
Task/Issue URL: https://app.asana.com/0/1201493110486074/1208686320819590/f
iOS PR: duckduckgo/iOS#3530
macOS PR: duckduckgo/macos-browser#3497
What kind of version bump will this require?: Minor
Description:
On investigating a hard-to-reproduce issue with sync, I noticed there's a gap in error reporting when the secure storage (keychain) is not available. This adds a pixel for that case.
Steps to test this PR:
Just a pixel in an error case. Hard to test without altering code. But if you do want to do that:
Enable sync
Change BSK.DDGSync.SecureStorage.account() to throw every time
Go to the Settings -> Sync screen
You should see the
sync_secure_storage_read_errorPixel in the debug consoleOS Testing:
Internal references:
Software Engineering Expectations
Technical Design Template