Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rule for gdpr-legal-cookie CMP #636

Merged
merged 2 commits into from
Feb 18, 2025
Merged

Add rule for gdpr-legal-cookie CMP #636

merged 2 commits into from
Feb 18, 2025

Conversation

noisysocks
Copy link
Contributor

https://app.asana.com/0/1203268166580279/1206522960156513

Selectors are fairly generic so decided to detect CMP using an object that’s set on window.

@noisysocks noisysocks added patch Increment the patch version when merged CMP labels Feb 13, 2025
@noisysocks noisysocks requested a review from muodov February 13, 2025 04:40
@noisysocks
Copy link
Contributor Author

Haven’t managed to get npm test to pass for this rule yet. Seemingly the popup doesn’t ever appear 🤔 will continue investigation tomorrow.

@noisysocks noisysocks merged commit a54d2b1 into main Feb 18, 2025
6 checks passed
@noisysocks noisysocks deleted the gdpr-legal-cookie branch February 18, 2025 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMP patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants