Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add artificial delay to the sourcepoint rule to mitigate race conditions #640

Merged
merged 1 commit into from
Feb 19, 2025
Merged

Add artificial delay to the sourcepoint rule to mitigate race conditions #640

merged 1 commit into from
Feb 19, 2025
+3 −0

Conversation

muodov
Copy link
Member

@muodov muodov commented Feb 14, 2025

@muodov muodov requested a review from noisysocks February 14, 2025 16:03
@muodov muodov added the patch Increment the patch version when merged label Feb 14, 2025
noisysocks
noisysocks approved these changes Feb 18, 2025
View reviewed changes
Copy link
Contributor

@noisysocks noisysocks left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t love it but nor do I love the crazy alternative approaches I can come up with.

Before merging, can you please link to a ticket alongside the FIXME so that future developers have more context?

@muodov muodov merged commit be31fb7 into main Feb 19, 2025
8 checks passed
@muodov muodov deleted the max/source-point-delay branch February 19, 2025 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisysocks noisysocks noisysocks approved these changes

Assignees
No one assigned
Labels
patch Increment the patch version when merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@muodov @noisysocks