Skip to content

Update BSK path #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

samsymons
Copy link
Contributor

Task: https://app.asana.com/0/414235014887631/1209745503606409/f

This PR updates the BSK path to account for the changes in duckduckgo/apple-browsers#304, where BSK is being moved into a SharedPackages directory, allowing us to create other shared packages.

This repo is being updated to look for all changes in the SharedPackages directory, so that any new packages that are added will be included by default.

How to test:

  1. Check that CI is green
  2. Check that there are no other changes that need to be made to support the changes in Create SharedPackages directory apple-browsers#304

@samsymons samsymons requested review from kshann and ayoy March 23, 2025 22:20
Copy link
Contributor

@ayoy ayoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Remember to bump the patch component in version.rb

@samsymons samsymons merged commit 76d8991 into main Mar 26, 2025
2 checks passed
@samsymons samsymons deleted the sam/update-browserserviceskit-path-for-sharedpackages-change branch March 26, 2025 23:01
@ayoy
Copy link
Contributor

ayoy commented Mar 27, 2025

@samsymons What I meant was to update ./lib/fastlane/plugin/ddg_apple_automation/version.rb with the bumped version (the tag you would make after merging this PR) before merging. Now the 2.2.2 release in github identifies itself as 2.2.1. But actually it doesn’t seem to be breaking anything 😅 Anyway, let’s keep this in mind for the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants