Skip to content

Commit

Permalink
Use WebKit delegate flow for handling opening a new tab from _blank l…
Browse files Browse the repository at this point in the history
…inks
  • Loading branch information
miasma13 committed Nov 6, 2024
1 parent 1c2abb9 commit b8ddf87
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions DuckDuckGo/TabViewController.swift
Original file line number Diff line number Diff line change
Expand Up @@ -1974,8 +1974,8 @@ extension TabViewController: WKNavigationDelegate {
}

if isNewTargetBlankRequest(navigationAction: navigationAction) {
delegate?.tab(self, didRequestNewTabForUrl: url, openedByPage: true, inheritingAttribution: adClickAttributionLogic.state)
completion(.cancel)
// Continue loading as WKUIDelegate callback will handle opening a new tab in TabViewController.webView(_:createWebViewWith:for:windowFeatures:)
completion(.allow)
return
}

Expand Down

0 comments on commit b8ddf87

Please sign in to comment.