Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep DuckDuckGo Settings after Fire Button #2444

Merged
merged 5 commits into from
Feb 6, 2024

Conversation

brindy
Copy link
Contributor

@brindy brindy commented Feb 6, 2024

Task/Issue URL: https://app.asana.com/0/414709148257752/1206511646424647/f
Tech Design URL:
CC:

Description:
Keep DDG cookies when fire button is used.

Replace #2433

Steps to test this PR:

  1. Change 'safe search' to 'off' on the SERP (or via settings in SERP menu). Change other settings too.
  2. Use the fire button
  3. Check the settings are retained.

DDG domain test:

  1. Login into use-devtesting2.duckduckgo.com (sorry)
  2. Change some settings on that site
  3. Ensure they are retained

@brindy brindy changed the title fix keep ddg cookies2 Keep DuckDuckGo Settings after Fire Button Feb 6, 2024
Copy link
Contributor

@dus7 dus7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

let cookieStorage = CookieStorage()
let idManager = DataStoreIdManager()
for test in referenceTests {
guard let cookie = cookie(for: test) else {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find it better to use try XCTUnwrap with a throwing test function in such cases. It gives you automatic error message :).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah very nice, will use that.

@brindy brindy merged commit cef5f51 into release/7.108.0 Feb 6, 2024
10 checks passed
@brindy brindy deleted the brindy/fix-keep-ddg-cookies2 branch February 6, 2024 12:07
samsymons added a commit that referenced this pull request Feb 8, 2024
# By Mariusz Śpiewak (11) and others
# Via Bartek Waresiak (3) and others
* main: (52 commits)
  Release 7.108.0-3 (#2454)
  User Authentication (#2431)
  Fix BSK reference to tagged version (#2447)
  Set proper border color for widgets (#2446)
  Check subfeature state before reading rollout data (#2426)
  Remove the mock VPN invite code (#2442)
  Release 7.108.0-2 (#2445)
  Keep DuckDuckGo Settings after Fire Button (#2444)
  Release 7.108.0-1 (#2440)
  Release 7.107.1-1 (#2439)
  Updates internal user flag to reset state (#2438)
  Release 7.107.1-0 (#2437)
  Hide the debug menu when debug mode is not enabled (#2436)
  Autoconsent 9.7.2 (#2425)
  Release 7.108.0-0 (#2432)
  Autofill: Fix footer sizing for multiline labels (#2422)
  Add rollout for cookie popup management enabled by default (#2373)
  Update BSK with autofill 10.1.0 (#2414)
  Bump submodules/privacy-reference-tests from `a3acc21` to `6b7ad1e` (#2408)
  Add Autoconsent onByDefault subfeature (#2423)
  ...

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants