Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release PR] Fix waitlist beta metadata check #2674

Merged

Conversation

samsymons
Copy link
Contributor

Task/Issue URL: https://app.asana.com/0/414235014887631/1207001617932318/f
Tech Design URL:
CC:

Description:

This PR changes the check we use to tell if someone is a beta user.

Steps to test this PR:

  1. Get yourself into a waitlist invited state (basically just have some waitlist state in the keychain, with an invite code)
  2. Go to the Debug menu's Network Protection section and check that your metadata is flagging you as a beta user

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

Copy link
Member

@quanganhdo quanganhdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@samsymons samsymons merged commit 78902d3 into release/7.114.0 Apr 4, 2024
13 checks passed
@samsymons samsymons deleted the sam/release-pr-fix-waitlist-metadata-check branch April 4, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants