Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce subscription check #2677

Merged
merged 4 commits into from
Apr 4, 2024

Conversation

quanganhdo
Copy link
Member

@quanganhdo quanganhdo commented Apr 4, 2024

Task/Issue URL: https://app.asana.com/0/414235014887631/1207003140495066/f
Tech Design URL:
CC:

Description:

Enforces subscription check when app becomes active

Steps to test this PR:
1.
2.

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

Copy link
Contributor

@samsymons samsymons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending one pixel addition that we discussed. I'll make the change for you.

@quanganhdo quanganhdo merged commit 96954a4 into release/7.114.0 Apr 4, 2024
18 checks passed
@quanganhdo quanganhdo deleted the anh/netp/enforce-subscription-check branch April 4, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants