Fix status bar color on regular width size class #2705
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/414235014887631/1207036066535091/f
Tech Design URL:
CC: @federicocappelli
Description:
Fixes invalid status bar color when in dark mode in iPad. Original check was not working since the decorate function was called only in
viewDidLoad
and the width was set to0
. I’ve modified the check to include size class.Steps to test this PR:
Orientation Testing:
Device Testing:
Theme Testing:
—
Internal references:
Software Engineering Expectations
Technical Design Template