Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix status bar color on regular width size class #2705

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

dus7
Copy link
Contributor

@dus7 dus7 commented Apr 9, 2024

Task/Issue URL: https://app.asana.com/0/414235014887631/1207036066535091/f
Tech Design URL:
CC: @federicocappelli

Description:

Fixes invalid status bar color when in dark mode in iPad. Original check was not working since the decorate function was called only in viewDidLoad and the width was set to 0. I’ve modified the check to include size class.

Steps to test this PR:

  1. Open app on iPad.
  2. Enable dark mode.
  3. Enable split view and play with the size ratio.

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone 14 Pro
  • iPad

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@dus7 dus7 changed the base branch from main to release/7.115.0 April 9, 2024 17:05
@dus7 dus7 force-pushed the mariusz/fix-status-bar-color branch from de36dfc to e082afb Compare April 9, 2024 17:05
@dus7 dus7 marked this pull request as ready for review April 9, 2024 17:06
Copy link
Contributor

@brindy brindy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dus7 dus7 merged commit 161bad3 into release/7.115.0 Apr 10, 2024
18 checks passed
@dus7 dus7 deleted the mariusz/fix-status-bar-color branch April 10, 2024 10:45
samsymons added a commit that referenced this pull request Apr 12, 2024
# By Mariusz Śpiewak (4) and others
# Via Chris Brind (1) and others
* main:
  Reverting accidental push to main (#2718)
  Add SubscriptionContainerViewModel and
  Manually hide loader + Pixel (#2687)
  Release 7.115.0-2 (#2712)
  soft revert history suggestions (#2711)
  Bring back accessibility identifiers for onboarding buttons (#2709)
  BSK release 133.1.0 (#2708)
  Password Manager widget and app shortcut (#2619)
  Release 7.115.0-1 (#2707)
  Update set-as-default onboarding illustration for dark mode (#2694)
  update app store prompt logic (#2678)
  Fix status bar color on regular width size class (#2705)
  Updated settings (#2603)
  Update BSK with autofill 11.0.1 (#2704)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants