Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use WebKit delegate flow for handling opening a new tab from _blank links #3551

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

miasma13
Copy link
Contributor

@miasma13 miasma13 commented Nov 6, 2024

Task/Issue URL: https://app.asana.com/0/414709148257752/1208699273169079/f

Description:
In https://app.asana.com/0/414709148257752/1208699273169079/f it was identified that opening new tab via links with "_blank" target results in trimming referrer or sometimes broken flows. The previous logic used cancelling the navigation and opening a new tab followed by manual trigger to load target URL.
After investigation this approach was discouraged in favour of allowing the navigation and handling opening the new tab via WKUIDelegate callback in TabViewController.webView(_:createWebViewWith:for:windowFeatures:)

Steps to test this PR:

  1. Open https://www.svcbank.com/personal-netbanking

  2. Tap Continue To Login button
    Expected: A new tab with the login page should open

  3. Open http://miasma13.github.io/downloads.html

  4. Tap What are my headers link
    Expected: Check in the summary for referer header to properly list original page

Retest navigation with various means of opening a new tab (including via JS calls)

Definition of Done (Internal Only):

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 15
  • iOS 16
  • iOS 17

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

Copy link

This PR has been inactive for more than 7 days and will be automatically closed 7 days from now.

@github-actions github-actions bot added the stale label Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant