Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

point at BSK branch #3558

Closed
wants to merge 1 commit into from
Closed

point at BSK branch #3558

wants to merge 1 commit into from
+4 −4

Conversation

SabrinaTardio
Copy link
Contributor

@SabrinaTardio SabrinaTardio commented Nov 8, 2024 •
edited
Loading

Task/Issue URL: https://app.asana.com/0/1204186595873227/1208687542689224/f
Tech Design URL: https://app.asana.com/0/481882893211075/1208680035673275/f
CC:

Description: Points to BSK branch

Steps to test this PR:

  1. Check Tests are green
  2. No PrivacyConfig related errors

Definition of Done (Internal Only):

Copy Testing:

  • Use of correct apostrophes in new copy, ie ’ rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 15
  • iOS 16
  • iOS 17

Theme Testing:

  • Light theme
  • Dark theme
Internal references:

Software Engineering Expectations
Technical Design Template

@SabrinaTardio SabrinaTardio marked this pull request as ready for review November 8, 2024 12:33
@SabrinaTardio SabrinaTardio requested review from jaceklyp and removed request for jaceklyp November 8, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@SabrinaTardio