Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix favorites grid layout issues on New Tab Page #3568

Merged
merged 2 commits into from
Nov 12, 2024
Merged

Fix favorites grid layout issues on New Tab Page #3568

merged 2 commits into from
Nov 12, 2024

Conversation

dus7
Copy link
Contributor

@dus7 dus7 commented Nov 12, 2024 •
edited
Loading

Task/Issue URL: https://app.asana.com/0/1206226850447395/1208709136086082/f
Tech Design URL:
CC:

Description:

Addresses feedback around updated favorites grid layout on New Tab Page.

  • Uses static column setup with 4 columns on iPhone and 5 on iPad when NTP customization is turned off.
  • Reduces the width of grid and makes it centered.
  • A special case handled for smaller screens so the static layout does not exceed margins.

Steps to test this PR:
For best baseline run 7.142.1 or earlier.

  1. Add at least 5 favorites
  2. Verify number of columns shown and their count does not change when rotated to landscape:
    a. 4 on iPhone
    b. 5 on iPad (unless in compact-sized Split View)

Definition of Done (Internal Only):

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 16 Pro
  • iPad

OS Testing:

  • iOS 15
  • iOS 16
  • iOS 18

Theme Testing:

  • Light theme
  • Dark theme
Internal references:

Software Engineering Expectations
Technical Design Template

@dus7 dus7 marked this pull request as ready for review November 12, 2024 15:29
@dus7 dus7 requested a review from brindy November 12, 2024 15:29
@dus7 dus7 changed the base branch from main to release/7.145.0 November 12, 2024 15:32
brindy
brindy approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@brindy brindy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested phone and iPad in both orientations. LGTM

@dus7 dus7 merged commit d62e0c4 into release/7.145.0 Nov 12, 2024
27 of 28 checks passed
@dus7 dus7 deleted the mariusz/fix-ntp-issues branch November 12, 2024 17:06
samsymons added a commit that referenced this pull request Nov 13, 2024
@samsymons
Merge branch 'main' into dominik/xcode-16
7f9ac0e 
* main:
  Release 7.145.0-2 (#3570)
  Fix favorites grid layout issues on New Tab Page (#3568)
  Import Add To Dock Translations (#3566)
  Release 7.145.0-1 (#3567)
  Remove Old onboarding intro (#3554)
  fix showing current tab in suggestions (#3562)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brindy brindy brindy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dus7 @brindy