Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set dryRun for VPN and alpha pixels #3578

Merged
merged 2 commits into from
Nov 16, 2024
Merged

Conversation

samsymons
Copy link
Contributor

@samsymons samsymons commented Nov 14, 2024

Task/Issue URL: https://app.asana.com/0/414235014887631/1208771566285225/f
Tech Design URL:
CC:

Description:

This PR updates the dryRun check to be set for all debug builds. Previously, it was only being set for non-alpha builds, meaning that if you ran a debug alpha build, you were firing real pixels (and in one case, causing a pixel anomaly 😬).

This changes was originally done since the alpha build was always setting DEBUG, but that's no longer true so the dryRun check can be simplified.

Steps to test this PR:

  1. Run the alpha build locally and check that pixels are logged, not sent
  2. Do the same for the VPN extension, just start the VPN locally and make sure no real pixel calls are made

Definition of Done (Internal Only):

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 15
  • iOS 16
  • iOS 17

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@samsymons samsymons merged commit 260b44b into main Nov 16, 2024
21 checks passed
@samsymons samsymons deleted the sam/set-dryrun-for-vpn-and-alpha branch November 16, 2024 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants