Set dryRun
for VPN and alpha pixels
#3578
Merged
+5
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/414235014887631/1208771566285225/f
Tech Design URL:
CC:
Description:
This PR updates the
dryRun
check to be set for all debug builds. Previously, it was only being set for non-alpha builds, meaning that if you ran a debug alpha build, you were firing real pixels (and in one case, causing a pixel anomaly 😬).This changes was originally done since the alpha build was always setting
DEBUG
, but that's no longer true so thedryRun
check can be simplified.Steps to test this PR:
Definition of Done (Internal Only):
Device Testing:
OS Testing:
Theme Testing:
Internal references:
Software Engineering Expectations
Technical Design Template