-
Notifications
You must be signed in to change notification settings - Fork 10
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Don't show key icon for empty passwords (#2962)
Task/Issue URL: https://app.asana.com/0/1202926619870900/1207697076491402/f Tech Design URL: https://app.asana.com/0/481882893211075/1207750849382981 **Description**: There has been an issue around for some time where the autofill key icon (indicating that there is autofill data for that field) was showing in the password field despite there being no password stored for a domain. This was because we were using the existence of any stored data for that domain as the source of truth for showing the icon in both username and password fields. **Steps to test this PR**: 1. Go to More (...) -> autofill 2. Make sure there are no other login for the domain https://fill.dev/ 3. Add a login for the domain https://fill.dev/, filling in the username field but not the password field. 4. Visit https://fill.dev/ 5. **Observe there is a key icon in the username field but not the password** 6. Repeat step 1 7. Find the login added in step 3 and add a password. 8. Refresh the https://fill.dev/ page. 9. **Observe there are key icons in both fields** **Definition of Done**: * [ ] Does this PR satisfy our [Definition of Done](https://app.asana.com/0/1202500774821704/1207634633537039/f)? --- ###### Internal references: [Pull Request Review Checklist](https://app.asana.com/0/1202500774821704/1203764234894239/f) [Software Engineering Expectations](https://app.asana.com/0/59792373528535/199064865822552) [Technical Design Template](https://app.asana.com/0/59792373528535/184709971311943) [Pull Request Documentation](https://app.asana.com/0/1202500774821704/1204012835277482/f)
- Loading branch information
Showing
6 changed files
with
26 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters