Update VPN extension display names (#3202)

Task/Issue URL: https://app.asana.com/0/1199230911884351/1208218767599955/f Tech Design URL: CC: Description: This PR adds a display name to the VPN extensions, for use in macOS 15.
duckduckgo · Sep 8, 2024 · 8129e53 · 8129e53
1 parent e00cd9b
commit 8129e53
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 9 deletions.
diff --git a/Configuration/Extensions/NetworkProtection/NetworkProtectionAppExtension.xcconfig b/Configuration/Extensions/NetworkProtection/NetworkProtectionAppExtension.xcconfig
@@ -16,6 +16,8 @@
 #include "../ExtensionBase.xcconfig"
 #include "../../AppStore.xcconfig"
 
+INFOPLIST_KEY_CFBundleDisplayName = DuckDuckGo VPN Network Extension
+
 CODE_SIGN_ENTITLEMENTS[config=CI][sdk=macosx*] =
 CODE_SIGN_ENTITLEMENTS[config=Debug][sdk=macosx*] = DuckDuckGo/NetworkProtectionAppExtension.entitlements
 CODE_SIGN_ENTITLEMENTS[config=Release][sdk=macosx*] = DuckDuckGo/NetworkProtectionAppExtension.entitlements

diff --git a/Configuration/Extensions/NetworkProtection/NetworkProtectionSystemExtension.xcconfig b/Configuration/Extensions/NetworkProtection/NetworkProtectionSystemExtension.xcconfig
@@ -16,6 +16,8 @@
 #include "../ExtensionBase.xcconfig"
 #include "../../DeveloperID.xcconfig"
 
+INFOPLIST_KEY_CFBundleDisplayName = DuckDuckGo VPN Network Extension
+
 CODE_SIGN_ENTITLEMENTS[config=CI][sdk=macosx*] =
 CODE_SIGN_ENTITLEMENTS[config=Debug][sdk=macosx*] = NetworkProtectionSystemExtension/NetworkProtectionSystemExtension_Debug.entitlements
 CODE_SIGN_ENTITLEMENTS[config=Release][sdk=macosx*] = NetworkProtectionSystemExtension/NetworkProtectionSystemExtension_Release.entitlements

diff --git a/NetworkProtectionAppExtension/InfoPlist.xcstrings b/NetworkProtectionAppExtension/InfoPlist.xcstrings
@@ -8,55 +8,55 @@
         "de" : {
           "stringUnit" : {
             "state" : "translated",
-            "value" : "NetworkProtectionAppExtension"
+            "value" : "DuckDuckGo VPN Network Extension"
           }
         },
         "en" : {
           "stringUnit" : {
             "state" : "new",
-            "value" : "NetworkProtectionAppExtension"
+            "value" : "DuckDuckGo VPN Network Extension"
           }
         },
         "es" : {
           "stringUnit" : {
             "state" : "translated",
-            "value" : "NetworkProtectionAppExtension"
+            "value" : "DuckDuckGo VPN Network Extension"
           }
         },
         "fr" : {
           "stringUnit" : {
             "state" : "translated",
-            "value" : "NetworkProtectionAppExtension"
+            "value" : "DuckDuckGo VPN Network Extension"
           }
         },
         "it" : {
           "stringUnit" : {
             "state" : "translated",
-            "value" : "NetworkProtectionAppExtension"
+            "value" : "DuckDuckGo VPN Network Extension"
           }
         },
         "nl" : {
           "stringUnit" : {
             "state" : "translated",
-            "value" : "NetworkProtectionAppExtension"
+            "value" : "DuckDuckGo VPN Network Extension"
           }
         },
         "pl" : {
           "stringUnit" : {
             "state" : "translated",
-            "value" : "NetworkProtectionAppExtension"
+            "value" : "DuckDuckGo VPN Network Extension"
           }
         },
         "pt" : {
           "stringUnit" : {
             "state" : "translated",
-            "value" : "NetworkProtectionAppExtension"
+            "value" : "DuckDuckGo VPN Network Extension"
           }
         },
         "ru" : {
           "stringUnit" : {
             "state" : "translated",
-            "value" : "NetworkProtectionAppExtension"
+            "value" : "DuckDuckGo VPN Network Extension"
           }
         }
       }