Add timelineEvents to DBPUIDataBrokerProfileMatch #3535
Closed
+209
−68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quanganhdo
commented
Nov 12, 2024
...ckages/DataBrokerProtection/Sources/DataBrokerProtection/Model/DBPUICommunicationModel.swift
Outdated
Show resolved
Hide resolved
quanganhdo
force-pushed
the
anh/pir/timeline-events
branch
from
e456339
to
ad9ce10
Compare
quanganhdo
force-pushed
the
anh/pir/timeline-events
branch
from
f3e3967
to
dfd97aa
Compare
| } | ||
|
|
||
| if let removedEvent = DBPUITimelineEvent(removedDate: removedDate) { | ||
| timelineEvents.append(removedEvent) |
There was a problem hiding this comment.
Am I right in thinking that if the entry has been removed, then the timeline will have an estimated removal date event, followed by an actual removed event? Is that what we want?
There was a problem hiding this comment.
Ah good point. Logically we shouldn't have the estimated removal date when the profile has been removed 😅
...ckages/DataBrokerProtection/Sources/DataBrokerProtection/Model/DBPUICommunicationModel.swift
Show resolved
Hide resolved
|
Closing this PR, let's revisit it later outside the scope of my project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1208663928051298/f
Tech Design URL: https://app.asana.com/0/481882893211075/1208663928051302
CC:
Description:
Replace existing date fields with timelineEvents
Steps to test this PR:
Definition of Done:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation