Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addAttempt workaround #3556

Open
wants to merge 1 commit into
base: anh/pir/update-preferred-run-date-after-removal
Choose a base branch
from

Conversation

quanganhdo
Copy link
Member

Task/Issue URL: https://app.asana.com/0/1205591970852438/1208761697124514/f
Tech Design URL:
CC:

Description:

Workaround to deal with OptOutAttemptDB having one-to-one relationship with ExtractedProfileDB.

The idea is to let subsequent attempts overwrite the previous one. Associated pixels should've already been fired, so no data loss. This would allow the opt-out operation to finish cleanly, add the right history events, and fire the correct pixels.

Steps to test this PR:

This is quite time consuming to verify. You may use this branch for sped up process: https://github.com/duckduckgo/macos-browser/tree/anh/pir/resubmit-opt-outs-pr-review

  1. Go through the DBP flow
  2. Move the system time forward so that DBP does another scan/opt-out passes
  3. As opt-out retries are done, you should see attemptCount being incremented in the DB browser

Definition of Done:


Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

Copy link
Contributor

@aataraxiaa aataraxiaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested as follows:

  • Ran an initial scan
  • Set system time a week forward
  • Waited
  • Checked DB Browser and saw some rows with attemptCount of 1

From the instructions I believe this matches expectations. See screenshot.

Screenshot 2024-11-16 at 12 57 44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants