Skip to content

Bebop: exclude null trades #8308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

B1boid
Copy link
Contributor

@B1boid B1boid commented Jun 4, 2025

Added protection from zero trades that causes infinite volume, mentioned in #8185 (comment)
Deleted prod_exclude tag for bebop_blend_ethereum_trades

@github-actions github-actions bot marked this pull request as draft June 4, 2025 10:57
@github-actions github-actions bot added WIP work in progress dbt: dex covers the DEX dbt subproject labels Jun 4, 2025
@dune-eng
Copy link

dune-eng commented Jun 4, 2025

Workflow run id 15440499850 approved.

@dune-eng
Copy link

dune-eng commented Jun 4, 2025

Workflow run id 15440499853 approved.

@dune-eng
Copy link

dune-eng commented Jun 4, 2025

Workflow run id 15440499965 approved.

@dune-eng
Copy link

dune-eng commented Jun 4, 2025

Workflow run id 15442077145 approved.

@dune-eng
Copy link

dune-eng commented Jun 4, 2025

Workflow run id 15442077106 approved.

@dune-eng
Copy link

dune-eng commented Jun 4, 2025

Workflow run id 15442077490 approved.

@B1boid B1boid marked this pull request as ready for review June 4, 2025 12:33
@github-actions github-actions bot added ready-for-review this PR development is complete, please review and removed WIP work in progress labels Jun 4, 2025
@dune-eng
Copy link

dune-eng commented Jun 4, 2025

Workflow run id 15442389421 approved.

@jeff-dude
Copy link
Member

jeff-dude commented Jun 9, 2025

thanks for revisiting to re-enable.
i have triggered the attached CI pipeline workflow to run again and rebuild tables.
can you grab the temp table names from CI logs once complete and query to ensure amount_usd values aren't inflated?

edit: CI tables will persist until the weekend.

@jeff-dude jeff-dude added in review Assignee is currently reviewing the PR and removed ready-for-review this PR development is complete, please review labels Jun 9, 2025
@B1boid
Copy link
Contributor Author

B1boid commented Jun 10, 2025

thanks for revisiting to re-enable. i have triggered the attached CI pipeline workflow to run again and rebuild tables. can you grab the temp table names from CI logs once complete and query to ensure amount_usd values aren't inflated?

edit: CI tables will persist until the weekend.

Thank you! Everything looks good, no crazy amounts: https://dune.com/queries/5260571/8641951/

@jeff-dude jeff-dude added ready-for-merging and removed in review Assignee is currently reviewing the PR labels Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dbt: dex covers the DEX dbt subproject ready-for-merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants