CUR2-263 taiko to base trades #8502
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
WIP
There was a problem hiding this comment.
Pull Request Overview
This PR implements DEX (Decentralized Exchange) trade tracking for the Taiko blockchain by adding base trade models for four platforms: Oku, Unagi V2/V3, and Izumi. The implementation follows the standard Spellbook pattern for DEX integrations.
- Adds source definitions for DEX event tables from four platforms on Taiko
- Creates individual base trade models for each platform using existing Uniswap-compatible macros
- Implements a unified aggregation model that combines all platform trades
- Adds comprehensive test coverage with seed data validation
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| sources/_sector/dex/trades/taiko/_sources.yml | Defines event table sources for Oku, Unagi V2/V3, and Izumi DEX platforms |
| dbt_subprojects/dex/seeds/trades/_schema.yml | Adds seed data schemas for testing each platform's base trades |
| dbt_subprojects/dex/models/trades/taiko/platforms/*.sql | Individual platform models that transform raw events into standardized trade data |
| dbt_subprojects/dex/models/trades/taiko/dex_taiko_base_trades.sql | Unified model aggregating all platform trades with transaction metadata |
| dbt_subprojects/dex/models/trades/taiko/_schema.yml | Defines model metadata, tests, and documentation for all Taiko DEX models |
Comments suppressed due to low confidence (1)
dbt_subprojects/dex/models/trades/taiko/platforms/oku_v3_taiko_base_trades.sql:3
- The schema name 'oku_v3_taiko' is inconsistent with the project name. Based on the source definition, this should be 'oku_taiko' to match the source name 'oku_taiko'.
schema = 'oku_v3_taiko',
dbt_subprojects/dex/models/trades/taiko/platforms/izumi_taiko_base_trades.sql
Outdated
Show resolved
Hide resolved
github-actions
bot
added
ready-for-review
jeff-dude
requested changes
Jul 22, 2025
dbt_subprojects/dex/models/trades/taiko/platforms/izumi_finance_taiko_base_trades.sql
Show resolved
Hide resolved
dbt_subprojects/dex/models/trades/taiko/platforms/izumi_finance_taiko_base_trades.sql
Show resolved
Hide resolved
jeff-dude
added
in review
…spellbook into taiko_into_trades
krishgka
added
ready-for-review
jeff-dude
approved these changes
Jul 23, 2025
jeff-dude
added
ready-for-merging
and removed
ready-for-review
jeff-dude
requested changes
Jul 25, 2025
jeff-dude
approved these changes
Jul 25, 2025
github-actions
bot
added
ready-for-review
jeff-dude
added
ready-for-merging
and removed
ready-for-review
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Spellbook 🪄
Please open the PR in draft and mark as ready when you want to request a review.
Description:
[...]
quick links for more information: