Skip to content

Quick fix Dex.trades: Fix fluid dex native addresses (Base & Arbitrum) #8514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 23, 2025

Conversation

henrystats
Copy link
Contributor

@jeff-dude the native addresses in the base & arbitrum models were mapped to the WETH addresses on ethereum, since Fluid doesn't have a lot of assets and most of them have prices, I'm guessing that's why the error wasn't picked up earlier!

@github-actions github-actions bot added WIP work in progress dbt: dex covers the DEX dbt subproject labels Jul 22, 2025
@henrystats henrystats changed the title Quick fix: Fix fluid dex native addresses (Base & Arbitrum) Quick fix Dex.trades: Fix fluid dex native addresses (Base & Arbitrum) Jul 22, 2025
@dune-eng
Copy link

Workflow run id 16431763679 approved.

@dune-eng
Copy link

Workflow run id 16431763829 approved.

@dune-eng
Copy link

Workflow run id 16431763690 approved.

@dune-eng
Copy link

Workflow run id 16432360039 approved.

@dune-eng
Copy link

Workflow run id 16432360031 approved.

@dune-eng
Copy link

Workflow run id 16432360304 approved.

@henrystats henrystats marked this pull request as ready for review July 22, 2025 02:03
@github-actions github-actions bot added ready-for-review this PR development is complete, please review and removed WIP work in progress labels Jul 22, 2025
@dune-eng
Copy link

Workflow run id 16432695357 approved.

Copy link
Member

@jeff-dude jeff-dude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

@jeff-dude jeff-dude self-assigned this Jul 22, 2025
@jeff-dude jeff-dude added ready-for-merging and removed ready-for-review this PR development is complete, please review labels Jul 22, 2025
@jeff-dude jeff-dude merged commit 0a48b70 into duneanalytics:main Jul 23, 2025
5 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dbt: dex covers the DEX dbt subproject ready-for-merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants