CUR2-299 superseed to dex trades #8515
Merged
+369
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
WIP
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for DEX trades on the superseed blockchain, integrating two DEX protocols: BulletX (v2 and v3) and Velodrome. The implementation follows the established pattern for adding new blockchain support to the spellbook project.
- Adds superseed blockchain support with BulletX v2/v3 and Velodrome DEX integration
- Creates base trade models using existing uniswap-compatible macros
- Integrates superseed trades into the main dex_base_trades aggregation
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| sources/_sector/dex/trades/superseed/_sources.yml | Defines source tables for BulletX and Velodrome on superseed |
| dbt_subprojects/dex/seeds/trades/*.csv | Creates empty seed files for trade validation tests |
| dbt_subprojects/dex/seeds/trades/_schema.yml | Adds schema definitions for the new seed files |
| dbt_subprojects/dex/models/trades/superseed/platforms/*.sql | Implements base trade models for each DEX protocol |
| dbt_subprojects/dex/models/trades/superseed/dex_superseed_base_trades.sql | Aggregates all superseed DEX trades |
| dbt_subprojects/dex/models/trades/superseed/_schema.yml | Defines model schemas and tests |
| dbt_subprojects/dex/models/trades/dex_base_trades.sql | Integrates superseed into main trades aggregation |
| dbt_subprojects/dex/models/dex_info.sql | Adds project information for new DEX protocols |
dbt_subprojects/dex/models/trades/superseed/dex_superseed_base_trades.sql
Show resolved
Hide resolved
krishgka
added
the
ready-for-review
jeff-dude
requested changes
Jul 25, 2025
dbt_subprojects/dex/models/trades/superseed/platforms/bulletx_v2_superseed_base_trades.sql
Outdated
Show resolved
Hide resolved
dbt_subprojects/dex/models/trades/superseed/platforms/bulletx_v2_superseed_base_trades.sql
Outdated
Show resolved
Hide resolved
dbt_subprojects/dex/models/trades/superseed/platforms/bulletx_v3_superseed_base_trades.sql
Outdated
Show resolved
Hide resolved
dbt_subprojects/dex/models/trades/superseed/platforms/bulletx_v3_superseed_base_trades.sql
Outdated
Show resolved
Hide resolved
github-actions
bot
added
WIP
…v2_superseed_base_trades.sql Co-authored-by: jeff-dude <[email protected]>
…v2_superseed_base_trades.sql Co-authored-by: jeff-dude <[email protected]>
…v3_superseed_base_trades.sql Co-authored-by: jeff-dude <[email protected]>
…v3_superseed_base_trades.sql Co-authored-by: jeff-dude <[email protected]>
Co-authored-by: jeff-dude <[email protected]>
github-actions
bot
added
ready-for-review
jeff-dude
approved these changes
Jul 25, 2025
jeff-dude
added
ready-for-merging
and removed
ready-for-review
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Spellbook 🪄
Please open the PR in draft and mark as ready when you want to request a review.
Description:
[...]
quick links for more information: