Update cow_protocol_polygon_trades.sql#8518
Conversation
fix hardcoded native token
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
github-actions
bot
added
WIP
|
Workflow run id 16445130012 approved. |
|
Workflow run id 16445129990 approved. |
|
Workflow run id 16445130348 approved. |
|
I have read the CLA Document and I hereby sign the CLA |
github-actions
bot
added
ready-for-review
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a hardcoded native token reference in the CoW Protocol Polygon trades SQL model by correcting the token symbol from 'AVAX' to 'POL' for ETH Flow orders.
- Updates the hardcoded native token symbol to use the correct Polygon token ('POL' instead of 'AVAX')
| case when sender is not null then sender else trader end as trader, | ||
| sell_token_address, | ||
| case when sender is not null then 'AVAX' else sell_token end as sell_token, | ||
| case when sender is not null then 'POL' else sell_token end as sell_token, |
There was a problem hiding this comment.
The hardcoded 'POL' token symbol may not be accurate for Polygon's native token. Polygon's native token is MATIC, and while POL was planned as a successor token, this should be verified against the current state of the Polygon network and the specific requirements of this data model.
jeff-dude
added
ready-for-merging
and removed
ready-for-review
|
Congrats, your important contribution to this open-source project has earned you a GitPOAP! GitPOAP: 2025 Dune Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
3 participants
fixed hardcoded native token